jenkins-bot has submitted this change and it was merged. Change subject: Make ext.flaggedRevs.review.css top loading ......................................................................
Make ext.flaggedRevs.review.css top loading This avoids FOUC and reflow of diff pages Bug: T138076 Change-Id: I94ddaa8edfa0869db507ae53dcf4b5531400d5f1 --- M frontend/FlaggedRevsUI.hooks.php M frontend/FlaggedRevsUI.setup.php 2 files changed, 7 insertions(+), 1 deletion(-) Approvals: Legoktm: Looks good to me, approved jenkins-bot: Verified diff --git a/frontend/FlaggedRevsUI.hooks.php b/frontend/FlaggedRevsUI.hooks.php index c474ad4..fcd07bc 100644 --- a/frontend/FlaggedRevsUI.hooks.php +++ b/frontend/FlaggedRevsUI.hooks.php @@ -24,6 +24,7 @@ # Add review form JS for reviewers if ( $wgUser->isAllowed( 'review' ) ) { $wgOut->addModules( 'ext.flaggedRevs.review' ); + $wgOut->addModuleStyles( 'ext.flaggedRevs.review.styles' ); } return true; } diff --git a/frontend/FlaggedRevsUI.setup.php b/frontend/FlaggedRevsUI.setup.php index 3fe5f2d..8f85c2e 100644 --- a/frontend/FlaggedRevsUI.setup.php +++ b/frontend/FlaggedRevsUI.setup.php @@ -153,7 +153,6 @@ ); $modules['ext.flaggedRevs.review'] = array( 'scripts' => array( 'ext.flaggedRevs.review.js' ), - 'styles' => array( 'ext.flaggedRevs.review.css' ), 'messages' => array( 'savearticle', 'tooltip-save', 'revreview-submitedit', 'revreview-submitedit-title', @@ -168,6 +167,12 @@ 'localBasePath' => $localModulePath, 'remoteExtPath' => $remoteModulePath, ); + $modules['ext.flaggedRevs.review.styles'] = array( + 'styles' => array( 'ext.flaggedRevs.review.css' ), + 'localBasePath' => $localModulePath, + 'remoteExtPath' => $remoteModulePath, + 'position' => 'top', + ); } /** -- To view, visit https://gerrit.wikimedia.org/r/296063 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I94ddaa8edfa0869db507ae53dcf4b5531400d5f1 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/FlaggedRevs Gerrit-Branch: master Gerrit-Owner: Umherirrender <umherirrender_de...@web.de> Gerrit-Reviewer: Aaron Schulz <asch...@wikimedia.org> Gerrit-Reviewer: Jackmcbarn <jackmcb...@gmail.com> Gerrit-Reviewer: Legoktm <legoktm.wikipe...@gmail.com> Gerrit-Reviewer: Umherirrender <umherirrender_de...@web.de> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits