Addshore has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/298987

Change subject: Count edit conflicts for each namespace separately
......................................................................

Count edit conflicts for each namespace separately

Change-Id: I5591f53063db32b2c74a2f74751d4af0ef5424d7
---
M includes/EditPage.php
1 file changed, 5 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/87/298987/1

diff --git a/includes/EditPage.php b/includes/EditPage.php
index 9c7ccdf..b1487e4 100644
--- a/includes/EditPage.php
+++ b/includes/EditPage.php
@@ -3513,13 +3513,11 @@
                if ( Hooks::run( 'EditPageBeforeConflictDiff', [ &$this, 
&$wgOut ] ) ) {
                        $stats = $wgOut->getContext()->getStats();
                        $stats->increment( 'edit.failures.conflict' );
-                       if ( $this->mTitle->isTalkPage() ) {
-                               $stats->increment( 
'edit.failures.conflict.byType.talk' );
-                       } else {
-                               $stats->increment( 
'edit.failures.conflict.byType.subject' );
-                       }
-                       if ( $this->mTitle->getNamespace() === NS_PROJECT ) {
-                               $stats->increment( 
'edit.failures.conflict.byNamespace.project' );
+                       if (
+                               $this->mTitle->getNamespace() >= NS_MAIN &&
+                               $this->mTitle->getNamespace() <= 
NS_CATEGORY_TALK
+                       ) {
+                               $stats->increment( 
'edit.failures.conflict.byNamespaceId.' . $this->mTitle->getNamespace() );
                        }
 
                        $wgOut->wrapWikiMsg( '<h2>$1</h2>', "yourdiff" );

-- 
To view, visit https://gerrit.wikimedia.org/r/298987
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5591f53063db32b2c74a2f74751d4af0ef5424d7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Addshore <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to