jenkins-bot has submitted this change and it was merged.
Change subject: Fix check for non-template-namespace transclusions
......................................................................
Fix check for non-template-namespace transclusions
These are not just titles beginning with ':'
Change-Id: I9d7063c221561a0e582deb6944eaab6d9ab4e3f7
---
M modules/ve-mw/dm/models/ve.dm.MWTransclusionModel.js
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve-mw/dm/models/ve.dm.MWTransclusionModel.js
b/modules/ve-mw/dm/models/ve.dm.MWTransclusionModel.js
index 72da8f3..1b020c9 100644
--- a/modules/ve-mw/dm/models/ve.dm.MWTransclusionModel.js
+++ b/modules/ve-mw/dm/models/ve.dm.MWTransclusionModel.js
@@ -250,6 +250,7 @@
/** */
ve.dm.MWTransclusionModel.prototype.fetch = function () {
var i, len, item, title, queue,
+ templateNamespaceId = mw.config.get( 'wgNamespaceIds'
).template,
titles = [],
specs = {};
@@ -271,7 +272,10 @@
// Skip titles that don't have a
resolvable href
title &&
// Skip titles outside the template
namespace
- title.charAt( 0 ) !== ':' &&
+ mw.Title.newFromText(
+ title,
+ templateNamespaceId
+ ).namespace === templateNamespaceId &&
// Skip already cached data
!hasOwn.call( specCache, title ) &&
// Skip duplicate titles in the same
batch
--
To view, visit https://gerrit.wikimedia.org/r/300952
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9d7063c221561a0e582deb6944eaab6d9ab4e3f7
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Alex Monk <a...@wikimedia.org>
Gerrit-Reviewer: Esanders <esand...@wikimedia.org>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
