Aaron Schulz has uploaded a new change for review.
https://gerrit.wikimedia.org/r/303310
Change subject: Fix inconsistent RevDelFileItem visibilities
......................................................................
Fix inconsistent RevDelFileItem visibilities
Bug: T142228
Change-Id: Ib5a0a1adbea2daf2b035cf6be367841362de03cc
---
M includes/revisiondelete/RevDelArchivedFileItem.php
M includes/revisiondelete/RevDelFileItem.php
2 files changed, 4 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/10/303310/1
diff --git a/includes/revisiondelete/RevDelArchivedFileItem.php
b/includes/revisiondelete/RevDelArchivedFileItem.php
index 39fb8ef..52df2e3 100644
--- a/includes/revisiondelete/RevDelArchivedFileItem.php
+++ b/includes/revisiondelete/RevDelArchivedFileItem.php
@@ -23,10 +23,8 @@
* Item class for a filearchive table row
*/
class RevDelArchivedFileItem extends RevDelFileItem {
- /** @var RevDelArchivedFileList */
- protected $list;
- /** @var ArchivedFile */
- protected $file;
+ /** @var $list RevDelArchivedFileList */
+ /** @var $file ArchivedFile */
/** @var LocalFile */
protected $lockFile;
diff --git a/includes/revisiondelete/RevDelFileItem.php
b/includes/revisiondelete/RevDelFileItem.php
index 3a3b467..ff01cee 100644
--- a/includes/revisiondelete/RevDelFileItem.php
+++ b/includes/revisiondelete/RevDelFileItem.php
@@ -23,10 +23,10 @@
* Item class for an oldimage table row
*/
class RevDelFileItem extends RevDelItem {
- /** @var OldLocalFile */
- public $file;
/** @var RevDelFileList */
protected $list;
+ /** @var OldLocalFile */
+ protected $file;
public function __construct( $list, $row ) {
parent::__construct( $list, $row );
--
To view, visit https://gerrit.wikimedia.org/r/303310
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib5a0a1adbea2daf2b035cf6be367841362de03cc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <asch...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
