Alexandros Kosiaris has uploaded a new change for review. https://gerrit.wikimedia.org/r/305486
Change subject: check_puppetrun: Remove old failure handling code ...................................................................... check_puppetrun: Remove old failure handling code Current versions of puppet actually do report the failure count in their events hash in the summary file, so remove the older version handling code Change-Id: I57934526193090efc0f8a731bfd196b58fff1a06 --- M modules/base/files/monitoring/check_puppetrun 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/86/305486/1 diff --git a/modules/base/files/monitoring/check_puppetrun b/modules/base/files/monitoring/check_puppetrun index 107f701..7026a69 100755 --- a/modules/base/files/monitoring/check_puppetrun +++ b/modules/base/files/monitoring/check_puppetrun @@ -75,8 +75,7 @@ unless summary.include?("events") failcount = :failed else - # and unless there are failures, the events hash just wont have the failure count - failcount = summary["events"]["failure"] || 0 + failcount = summary["events"]["failure"] end rescue failcount = :failed_to_parse_summary_file -- To view, visit https://gerrit.wikimedia.org/r/305486 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I57934526193090efc0f8a731bfd196b58fff1a06 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Alexandros Kosiaris <akosia...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits