Alexandros Kosiaris has submitted this change and it was merged.
Change subject: check_puppetrun: Remove old failure handling code
......................................................................
check_puppetrun: Remove old failure handling code
Current versions of puppet actually do report the failure count in their
events hash in the summary file, so remove the older version handling
code
Change-Id: I57934526193090efc0f8a731bfd196b58fff1a06
---
M modules/base/files/monitoring/check_puppetrun
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Giuseppe Lavagetto: Looks good to me, but someone else must approve
Alexandros Kosiaris: Verified; Looks good to me, approved
diff --git a/modules/base/files/monitoring/check_puppetrun
b/modules/base/files/monitoring/check_puppetrun
index 9897ade..355aa32 100755
--- a/modules/base/files/monitoring/check_puppetrun
+++ b/modules/base/files/monitoring/check_puppetrun
@@ -79,8 +79,7 @@
unless summary.include?("events")
failcount = :failed
else
- # and unless there are failures, the events hash just wont have
the failure count
- failcount = summary["events"]["failure"] || 0
+ failcount = summary["events"]["failure"]
end
rescue
failcount = :failed_to_parse_summary_file
--
To view, visit https://gerrit.wikimedia.org/r/305486
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I57934526193090efc0f8a731bfd196b58fff1a06
Gerrit-PatchSet: 3
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Alexandros Kosiaris <akosia...@wikimedia.org>
Gerrit-Reviewer: Alexandros Kosiaris <akosia...@wikimedia.org>
Gerrit-Reviewer: Gehel <gleder...@wikimedia.org>
Gerrit-Reviewer: Giuseppe Lavagetto <glavage...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
