Hashar has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330240 )
Change subject: tests: mock should not __clone Database
......................................................................
tests: mock should not __clone Database
The Database __clone relies on a connLogger which is set in the
constructor.
However, when creating a mock of Database, PHPUnit 5.x does a __clone
which uses a connLogger. That leads to a fatal error.
The sole caller is FileBackendDBRepoWrapperTest, have its mock to skip
invoking __clone().
Change-Id: I2ee3b561104bdacc0232ba5e90b3eae3fbaa6f8f
---
M tests/phpunit/includes/filerepo/FileBackendDBRepoWrapperTest.php
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/40/330240/1
diff --git a/tests/phpunit/includes/filerepo/FileBackendDBRepoWrapperTest.php
b/tests/phpunit/includes/filerepo/FileBackendDBRepoWrapperTest.php
index 410d2df..6c93c79a 100644
--- a/tests/phpunit/includes/filerepo/FileBackendDBRepoWrapperTest.php
+++ b/tests/phpunit/includes/filerepo/FileBackendDBRepoWrapperTest.php
@@ -113,6 +113,7 @@
protected function getMocks() {
$dbMock = $this->getMockBuilder( 'DatabaseMysqli' )
+ ->disableOriginalClone()
->disableOriginalConstructor()
->getMock();
--
To view, visit https://gerrit.wikimedia.org/r/330240
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2ee3b561104bdacc0232ba5e90b3eae3fbaa6f8f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Hashar <has...@free.fr>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
