Abhshkdz has uploaded a new change for review. https://gerrit.wikimedia.org/r/49982
Change subject: Some minor coding practice fixes; ...................................................................... Some minor coding practice fixes; There were a few lines in `SpecialVersion.php` that caused the build to be marked as failure. Fixing those: 1. Line 594 - String concat not required, so using single string instead Change-Id: I799d11aaaf953d09f681585ee23dc5bf496af3d4 --- M includes/specials/SpecialVersion.php 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/82/49982/1 diff --git a/includes/specials/SpecialVersion.php b/includes/specials/SpecialVersion.php index b04f1ef..669f404 100644 --- a/includes/specials/SpecialVersion.php +++ b/includes/specials/SpecialVersion.php @@ -594,8 +594,7 @@ */ private function IPInfo() { $ip = str_replace( '--', ' - ', htmlspecialchars( $this->getRequest()->getIP() ) ); - return "<!-- visited from $ip -->\n" . - "<span style='display:none'>visited from $ip</span>"; + return "<!-- visited from $ip --><span style='display:none'>visited from $ip</span>"; } /** -- To view, visit https://gerrit.wikimedia.org/r/49982 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I799d11aaaf953d09f681585ee23dc5bf496af3d4 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Abhshkdz <das.abh...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits