jenkins-bot has submitted this change and it was merged.
Change subject: Some minor coding practice fixes;
......................................................................
Some minor coding practice fixes;
There were a few lines in `SpecialVersion.php` that caused the build to
be marked as failure. Fixing those:
1. Line 594 - String concat not required, so using single string instead
Change-Id: I799d11aaaf953d09f681585ee23dc5bf496af3d4
---
M includes/specials/SpecialVersion.php
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Hashar: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/specials/SpecialVersion.php
b/includes/specials/SpecialVersion.php
index b04f1ef..88d647e 100644
--- a/includes/specials/SpecialVersion.php
+++ b/includes/specials/SpecialVersion.php
@@ -594,8 +594,7 @@
*/
private function IPInfo() {
$ip = str_replace( '--', ' - ', htmlspecialchars(
$this->getRequest()->getIP() ) );
- return "<!-- visited from $ip -->\n" .
- "<span style='display:none'>visited from $ip</span>";
+ return "<!-- visited from $ip -->\n<span
style='display:none'>visited from $ip</span>";
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/49982
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I799d11aaaf953d09f681585ee23dc5bf496af3d4
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Abhshkdz <das.abh...@gmail.com>
Gerrit-Reviewer: Abhshkdz <das.abh...@gmail.com>
Gerrit-Reviewer: Demon <ch...@wikimedia.org>
Gerrit-Reviewer: Hashar <has...@free.fr>
Gerrit-Reviewer: Matmarex <matma....@gmail.com>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
