Phuedx has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/350206 )
Change subject: Track and discard duplicate enqueued events ...................................................................... Track and discard duplicate enqueued events The eventLogging change listener is responsible for ensuring that the internal state of Page Previews matches its external state (that perceived by the user and UA). It does this by logging enqueued events with ext.eventLog.Schema#log. This makes it the perfect place to track and discard duplicate events enqueued by the Page Previews codebase observed in T161769. If no duplicate events are being enqueued, then we know that there's an issue in the EventLogging codebase or with the UA itself - particularly the implementation of Navigator#sendBeacon. Change listener changes: * Make the eventLogging change listener store enqueued events that it's logged by storing "hashes" of the dynamic parts of them in memory. * If the eventLogging change listener sees the same enqueued event more than once, then it dequeues the event and increments a counter in StatsD. Bug: T163198 Change-Id: I6a38a2619d777a76dd45eb7300079e1f07b07b12 --- M resources/dist/index.js M resources/dist/index.js.map M src/changeListeners/eventLogging.js M tests/node-qunit/changeListeners/eventLogging.test.js 4 files changed, 157 insertions(+), 46 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups refs/changes/06/350206/1 -- To view, visit https://gerrit.wikimedia.org/r/350206 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6a38a2619d777a76dd45eb7300079e1f07b07b12 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Popups Gerrit-Branch: master Gerrit-Owner: Phuedx <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
