jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/350206 )
Change subject: Track and discard duplicate enqueued events ...................................................................... Track and discard duplicate enqueued events The eventLogging change listener is responsible for ensuring that the internal state of Page Previews matches its external state (that perceived by the user and UA). It does this by logging events with ext.eventLog.Schema#log. This makes it the perfect place to track and discard duplicate events enqueued by the Page Previews codebase observed in T161769. Make the change listener track events that it's logged by storing hashes of the dynamic parts of them in memory. If the eventLogging change listener sees the same event more than once, then it discards it and increments a counter in StatsD. This behaviour should be enabled for a matter of days as we should see whether the duplicate events are being enqueued by the Page Previews codebase immediately. Bug: T163198 Change-Id: I6a38a2619d777a76dd45eb7300079e1f07b07b12 --- M resources/dist/index.js M resources/dist/index.js.map M src/changeListeners/eventLogging.js M src/index.js M tests/node-qunit/changeListeners/eventLogging.test.js 5 files changed, 281 insertions(+), 54 deletions(-) Approvals: jenkins-bot: Verified Phuedx: Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/350206 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a38a2619d777a76dd45eb7300079e1f07b07b12 Gerrit-PatchSet: 9 Gerrit-Project: mediawiki/extensions/Popups Gerrit-Branch: master Gerrit-Owner: Phuedx <[email protected]> Gerrit-Reviewer: Jdlrobson <[email protected]> Gerrit-Reviewer: Phuedx <[email protected]> Gerrit-Reviewer: Pmiazga <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
