Xqt has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/355118 )
Change subject: pep//flake chanches
......................................................................
pep//flake chanches
Change-Id: I3fdb4a820fe0703b6bb9bbf55e1d317790b9c00b
---
M imagereview.py
M tests/afd_notice_tests.py
M tests/imagereview_tests.py
M tox.ini
M vandalism.py
5 files changed, 9 insertions(+), 9 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/pywikibot/bots/xqbot
refs/changes/18/355118/1
diff --git a/imagereview.py b/imagereview.py
index dafd54b..268fec2 100644
--- a/imagereview.py
+++ b/imagereview.py
@@ -342,7 +342,7 @@
@property
def generator(self):
- """Generator property for images to be checked."""
+ """Retrieve images to be checked."""
cat = pywikibot.Category(self.site,
"%s:%s"
% (self.site.namespaces.CATEGORY.custom_name,
diff --git a/tests/afd_notice_tests.py b/tests/afd_notice_tests.py
index d3cbea5..fd977aa 100644
--- a/tests/afd_notice_tests.py
+++ b/tests/afd_notice_tests.py
@@ -38,7 +38,7 @@
@classmethod
def setUpClass(cls):
- """Setup Class."""
+ """Setup the Class."""
config.family = 'wikipedia'
config.mylang = 'de'
cls.bot = TestBot()
diff --git a/tests/imagereview_tests.py b/tests/imagereview_tests.py
index adaaabf..4a51b67 100644
--- a/tests/imagereview_tests.py
+++ b/tests/imagereview_tests.py
@@ -46,7 +46,7 @@
@classmethod
def setUpClass(cls):
- """Setup class."""
+ """Setup the class."""
super(TestDUP_Image, cls).setUpClass()
cls.site = pywikibot.Site('de', 'wikipedia')
cls.review_tpl = pywikibot.Page(cls.site, 'düp', 10)
@@ -78,13 +78,13 @@
self.image = imagereview.DUP_Image(self.site, 'Sample.jpg')
self.assertIsNone(self.image._contents)
self.assertIsNone(self.image._editTime)
- self.assertEqual(self.image._file_revisions, dict())
- self.assertEqual(self.image._revisions, dict())
+ self.assertEqual(self.image._file_revisions, {})
+ self.assertEqual(self.image._revisions, {})
self.assertIsNone(self.image.done)
self.assertFalse(self.image.info)
self.assertEqual(self.image.reasons, set())
self.assertIsNone(self.image.remark)
- self.assertEqual(self.image.review_tpl, list())
+ self.assertEqual(self.image.review_tpl, [])
def test_instance_with_content(self):
"""Test instance variables with content given."""
@@ -115,7 +115,7 @@
@classmethod
def setUpClass(cls):
- """Setup Class."""
+ """Setup the Class."""
config.family = 'wikipedia'
config.mylang = 'de'
diff --git a/tox.ini b/tox.ini
index 71866c9..d92a96f 100644
--- a/tox.ini
+++ b/tox.ini
@@ -64,7 +64,7 @@
require-code = true
putty-auto-ignore = true
putty-ignore =
- checkvotes.py : +D103, E501, N802, N806
+ checkvotes.py : +D103, D413, E501, N802, N806
imagereview.py : +N806
vandalism.py : +N801, N802, N803, N806
tests/checkvotes_tests.py, /from checkvotes import/ : +I100
diff --git a/vandalism.py b/vandalism.py
index fb238b7..b4caea5 100644
--- a/vandalism.py
+++ b/vandalism.py
@@ -142,7 +142,7 @@
self.defendant = defendant
self.accuser = accuser
self.timestamp = timestamp
- self.involved = set((defendant, accuser))
+ self.involved = set([defendant, accuser])
class vmBot(pywikibot.bot.SingleSiteBot):
--
To view, visit https://gerrit.wikimedia.org/r/355118
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3fdb4a820fe0703b6bb9bbf55e1d317790b9c00b
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/bots/xqbot
Gerrit-Branch: master
Gerrit-Owner: Xqt <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
