jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/355118 )
Change subject: pep//flake chanches
......................................................................
pep//flake chanches
Change-Id: I3fdb4a820fe0703b6bb9bbf55e1d317790b9c00b
---
M imagereview.py
M tests/imagereview_tests.py
M tox.ini
3 files changed, 8 insertions(+), 7 deletions(-)
Approvals:
jenkins-bot: Verified
Xqt: Looks good to me, approved
diff --git a/imagereview.py b/imagereview.py
index dafd54b..268fec2 100644
--- a/imagereview.py
+++ b/imagereview.py
@@ -342,7 +342,7 @@
@property
def generator(self):
- """Generator property for images to be checked."""
+ """Retrieve images to be checked."""
cat = pywikibot.Category(self.site,
"%s:%s"
% (self.site.namespaces.CATEGORY.custom_name,
diff --git a/tests/imagereview_tests.py b/tests/imagereview_tests.py
index adaaabf..00ad9bf 100644
--- a/tests/imagereview_tests.py
+++ b/tests/imagereview_tests.py
@@ -78,13 +78,13 @@
self.image = imagereview.DUP_Image(self.site, 'Sample.jpg')
self.assertIsNone(self.image._contents)
self.assertIsNone(self.image._editTime)
- self.assertEqual(self.image._file_revisions, dict())
- self.assertEqual(self.image._revisions, dict())
+ self.assertEqual(self.image._file_revisions, {})
+ self.assertEqual(self.image._revisions, {})
self.assertIsNone(self.image.done)
self.assertFalse(self.image.info)
self.assertEqual(self.image.reasons, set())
self.assertIsNone(self.image.remark)
- self.assertEqual(self.image.review_tpl, list())
+ self.assertEqual(self.image.review_tpl, [])
def test_instance_with_content(self):
"""Test instance variables with content given."""
diff --git a/tox.ini b/tox.ini
index 71866c9..ff9ff63 100644
--- a/tox.ini
+++ b/tox.ini
@@ -50,9 +50,10 @@
# The following are to be fixed
# D102: Missing docstring in public method
# D103: Missing docstring in public function
+# D401: First line should be in imperative mood; try rephrasing
# E402: module level import not at top of file; see T87409
# P102,P103: string does contain unindexed parameters; see I36355923
-ignore = D211,E115,E266,E402,FI10,FI12,FI15,FI5,P102
+ignore = D211,D401,E115,E266,E402,FI10,FI12,FI15,FI5,P102
exclude = .tox,.git,./*.egg,ez_setup.py,build
min-version = 2.7
max_line_length = 80
@@ -64,9 +65,9 @@
require-code = true
putty-auto-ignore = true
putty-ignore =
- checkvotes.py : +D103, E501, N802, N806
+ checkvotes.py : +D103, D413, E501, N802, N806
imagereview.py : +N806
- vandalism.py : +N801, N802, N803, N806
+ vandalism.py : +C405, N801, N802, N803, N806
tests/checkvotes_tests.py, /from checkvotes import/ : +I100
--
To view, visit https://gerrit.wikimedia.org/r/355118
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3fdb4a820fe0703b6bb9bbf55e1d317790b9c00b
Gerrit-PatchSet: 2
Gerrit-Project: pywikibot/bots/xqbot
Gerrit-Branch: master
Gerrit-Owner: Xqt <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
