jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/358917 )
Change subject: Removed unused global
......................................................................
Removed unused global
Change-Id: I229fee0b87e2f7027987d611b9b2676b987782d4
---
M FlaggedRevs.setup.php
M phpcs.xml
2 files changed, 1 insertion(+), 4 deletions(-)
Approvals:
jenkins-bot: Verified
Thiemo Mättig (WMDE): Looks good to me, approved
diff --git a/FlaggedRevs.setup.php b/FlaggedRevs.setup.php
index 01b5e49..9667724 100644
--- a/FlaggedRevs.setup.php
+++ b/FlaggedRevs.setup.php
@@ -126,7 +126,7 @@
* @return void
*/
public static function setAPIModules() {
- global $wgAPIModules, $wgAPIListModules, $wgAPIPropModules;
+ global $wgAPIModules, $wgAPIListModules;
global $wgFlaggedRevsProtection;
if ( $wgFlaggedRevsProtection ) {
diff --git a/phpcs.xml b/phpcs.xml
index e370545..bc4e29b 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -17,9 +17,6 @@
<rule ref="MediaWiki.NamingConventions.ValidGlobalName.wgPrefix">
<severity>0</severity>
</rule>
- <rule ref="MediaWiki.VariableAnalysis.UnusedGlobalVariables">
- <severity>0</severity>
- </rule>
<rule ref="PSR2.Methods.MethodDeclaration.AbstractAfterVisibility">
<severity>0</severity>
</rule>
--
To view, visit https://gerrit.wikimedia.org/r/358917
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I229fee0b87e2f7027987d611b9b2676b987782d4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/FlaggedRevs
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <[email protected]>
Gerrit-Reviewer: Jackmcbarn <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
