Matthias Mullie has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/358979 )

Change subject: Disable 3D rotation by keys
......................................................................

Disable 3D rotation by keys

They conflict with the existing arrow-based navigation for moving
between images.

Bug: T164565
Change-Id: I4d309930b39f2f45fcbc83cfee573a6332d860cc
---
M modules/mmv.3d.js
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/3D 
refs/changes/79/358979/1

diff --git a/modules/mmv.3d.js b/modules/mmv.3d.js
index 0d9fdbc..8526b25 100644
--- a/modules/mmv.3d.js
+++ b/modules/mmv.3d.js
@@ -49,6 +49,7 @@
                this.controls.addEventListener( 'change', $.proxy( function () 
{ threed.render(); }, threed ) );
                this.controls.addEventListener( 'start', $.proxy( function () { 
threed.controlsStart(); }, threed ) );
                this.controls.addEventListener( 'end', $.proxy( function () { 
threed.controlsEnd(); }, threed ) );
+               this.controls.enableKeys = false;
                this.controls.update();
 
                $( window ).on( 'resize.3d', $.debounce( 100, $.proxy( function 
() { threed.onWindowResize(); }, threed ) ) );

-- 
To view, visit https://gerrit.wikimedia.org/r/358979
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4d309930b39f2f45fcbc83cfee573a6332d860cc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/3D
Gerrit-Branch: master
Gerrit-Owner: Matthias Mullie <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to