Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366767 )

Change subject: Enable 
Generic.Formatting.MultipleStatementAlignment.IncorrectWarning and 
PSR2.Classes.PropertyDeclaration.ScopeMissing
......................................................................

Enable Generic.Formatting.MultipleStatementAlignment.IncorrectWarning and 
PSR2.Classes.PropertyDeclaration.ScopeMissing

Change-Id: Ib15918ad07d77b6cd90b84f184db913daca0d362
---
M phpcs.xml
M tests/DBList.php
M wmf-config/CommonSettings.php
3 files changed, 2 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/67/366767/1

diff --git a/phpcs.xml b/phpcs.xml
index 1ee13a2..b4b763d 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -30,13 +30,7 @@
        <rule ref="Generic.Files.LineLength.TooLong">
                <severity>0</severity>
        </rule>
-       <rule 
ref="Generic.Formatting.MultipleStatementAlignment.IncorrectWarning">
-               <severity>0</severity>
-       </rule>
        <rule ref="Generic.PHP.NoSilencedErrors.Discouraged">
-               <severity>0</severity>
-       </rule>
-       <rule ref="PSR2.Classes.PropertyDeclaration.ScopeMissing">
                <severity>0</severity>
        </rule>
        <rule ref="Squiz.Classes.ValidClassName.NotCamelCaps">
diff --git a/tests/DBList.php b/tests/DBList.php
index 37c0571..ea84b19 100644
--- a/tests/DBList.php
+++ b/tests/DBList.php
@@ -12,7 +12,7 @@
 class DBList {
        # List of project names. This array is used to verify that the various
        # dblist project files only contains names of databases that belong to 
them
-       static $wiki_projects = array(
+       private static $wiki_projects = array(
                'wikibooks',
                'wikinews',
                'wikipedia',
diff --git a/wmf-config/CommonSettings.php b/wmf-config/CommonSettings.php
index e2cfc76..5d77216 100644
--- a/wmf-config/CommonSettings.php
+++ b/wmf-config/CommonSettings.php
@@ -330,7 +330,7 @@
 $wgShowIPinHeader = false;
 $wgRCMaxAge = 30 * 86400;
 
-$wgTmpDirectory     = '/tmp';
+$wgTmpDirectory = '/tmp';
 
 $wgSQLMode = null;
 

-- 
To view, visit https://gerrit.wikimedia.org/r/366767
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib15918ad07d77b6cd90b84f184db913daca0d362
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Reedy <re...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to