C. Scott Ananian has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/378027 )
Change subject: Correct inheritance for CommentInspector actions
......................................................................
Correct inheritance for CommentInspector actions
CommentInspector inherits from NodeInspector, which doesn't create
any additional actions compared to its superclass FragmentInspector.
So this shouldn't change any behavior, but it's better practice
to inherit rather than hardcode a parent.
Change-Id: Ia95cba8d19788e33e0dd92e4bd994a3ebce20d38
---
M src/ui/inspectors/ve.ui.CommentInspector.js
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor
refs/changes/27/378027/1
diff --git a/src/ui/inspectors/ve.ui.CommentInspector.js
b/src/ui/inspectors/ve.ui.CommentInspector.js
index c6d27c1..358174e 100644
--- a/src/ui/inspectors/ve.ui.CommentInspector.js
+++ b/src/ui/inspectors/ve.ui.CommentInspector.js
@@ -40,7 +40,7 @@
flags: 'destructive',
modes: 'edit'
}
-].concat( ve.ui.FragmentInspector.static.actions );
+].concat( ve.ui.CommentInspector.super.static.actions );
/**
* Handle frame ready events.
--
To view, visit https://gerrit.wikimedia.org/r/378027
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia95cba8d19788e33e0dd92e4bd994a3ebce20d38
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: C. Scott Ananian <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
