jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/378027 )
Change subject: Correct inheritance for CommentInspector actions
......................................................................
Correct inheritance for CommentInspector actions
CommentInspector inherits from NodeInspector, which doesn't create
any additional actions compared to its superclass FragmentInspector.
So this shouldn't change any behavior, but it's better practice
to inherit rather than hardcode a parent.
Change-Id: Ia95cba8d19788e33e0dd92e4bd994a3ebce20d38
---
M src/ui/inspectors/ve.ui.CommentInspector.js
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
jenkins-bot: Verified
Jforrester: Looks good to me, approved
diff --git a/src/ui/inspectors/ve.ui.CommentInspector.js
b/src/ui/inspectors/ve.ui.CommentInspector.js
index c6d27c1..dbe6b70 100644
--- a/src/ui/inspectors/ve.ui.CommentInspector.js
+++ b/src/ui/inspectors/ve.ui.CommentInspector.js
@@ -40,7 +40,9 @@
flags: 'destructive',
modes: 'edit'
}
-].concat( ve.ui.FragmentInspector.static.actions );
+].concat( ve.ui.CommentInspector.super.static.actions );
+
+/* Methods */
/**
* Handle frame ready events.
--
To view, visit https://gerrit.wikimedia.org/r/378027
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia95cba8d19788e33e0dd92e4bd994a3ebce20d38
Gerrit-PatchSet: 2
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: C. Scott Ananian <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
