jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/378017 )
Change subject: Fire position event when direction is changed
......................................................................
Fire position event when direction is changed
Change-Id: Ia0c79667e4fefc27cca6ab321ca46664e092deb6
---
M src/ce/ve.ce.Surface.js
M src/ui/actions/ve.ui.ContentAction.js
2 files changed, 3 insertions(+), 2 deletions(-)
Approvals:
jenkins-bot: Verified
Jforrester: Looks good to me, approved
diff --git a/src/ce/ve.ce.Surface.js b/src/ce/ve.ce.Surface.js
index 85c4eb9..203ba60 100644
--- a/src/ce/ve.ce.Surface.js
+++ b/src/ce/ve.ce.Surface.js
@@ -233,8 +233,8 @@
*/
/**
- * When the surface changes its position (only if it happens
- * after initialize has already been called).
+ * When the surface or its contents changes position
+ * (only after initialize has already been called).
*
* @event position
*/
diff --git a/src/ui/actions/ve.ui.ContentAction.js
b/src/ui/actions/ve.ui.ContentAction.js
index ccc458e..0fe6271 100644
--- a/src/ui/actions/ve.ui.ContentAction.js
+++ b/src/ui/actions/ve.ui.ContentAction.js
@@ -110,6 +110,7 @@
var documentView = this.surface.getView().getDocument();
documentView.setDir( documentView.getDir() === 'ltr' ? 'rtl' : 'ltr' );
this.surface.getModel().emit( 'contextChange' );
+ this.surface.getView().emit( 'position' );
return true;
};
--
To view, visit https://gerrit.wikimedia.org/r/378017
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia0c79667e4fefc27cca6ab321ca46664e092deb6
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
