Jhernandez has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/379740 )
Change subject: New: Use application header in chrome
......................................................................
New: Use application header in chrome
Right now it only links to home on logo click.
* Also, removed unnecessary top spacing on App
Bug: T173022
Change-Id: I574f08573613e587e6d99d4c80c7fad5c2b348c2
---
M src/common/components/app/app.css
M src/common/components/app/app.tsx
2 files changed, 4 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/marvin refs/changes/40/379740/1
diff --git a/src/common/components/app/app.css
b/src/common/components/app/app.css
index 9cec12a..d41ee62 100644
--- a/src/common/components/app/app.css
+++ b/src/common/components/app/app.css
@@ -2,8 +2,8 @@
/* Expand the app box full height even if content doesn't fill it */
min-height: 100%;
- /* Provide top/bottom spacing, but not horizontal spacing */
- padding: var(--space) 0;
+ /* Provide bottom spacing, but not top or horizontal spacing */
+ padding: 0 0 var(--space) 0;
/* Cap max-width of app in big screens and center it horizontally */
/* TODO: Remove magic number and replace with variable, matching the
responsive cuts */
diff --git a/src/common/components/app/app.tsx
b/src/common/components/app/app.tsx
index 50bb6a4..e8fa318 100644
--- a/src/common/components/app/app.tsx
+++ b/src/common/components/app/app.tsx
@@ -1,14 +1,12 @@
import { h } from "preact";
import "./app.css";
import { ChildrenProps } from "../preact-utils";
-import Link from "../link";
+import Header from "../header/header";
export default function App({ children }: ChildrenProps): JSX.Element {
return (
<div class="App">
- <h5>
- <Link href="/">Home</Link>
- </h5>
+ <Header />
<div>{children}</div>
</div>
);
--
To view, visit https://gerrit.wikimedia.org/r/379740
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I574f08573613e587e6d99d4c80c7fad5c2b348c2
Gerrit-PatchSet: 1
Gerrit-Project: marvin
Gerrit-Branch: master
Gerrit-Owner: Jhernandez <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
