Jhernandez has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/379741 )
Change subject: Chore: Fix SVG rendering misbehaving on Safari ...................................................................... Chore: Fix SVG rendering misbehaving on Safari Both on desktop and iOS, the wordmark SVG specifically would some times turn the paths into fully filled rectangles. Apparently, the <base> tag affects the SVG imports with url and others, breaking them. Sources: * https://stackoverflow.com/a/18265336/1400662 * https://github.com/bodymovin/bodymovin/issues/360 * https://www.w3.org/2015/08/25-svg-minutes.html#item08 * https://github.com/angular/angular.js/issues/8934 I've tested all the URLs and the static assets seem to be loading fine, and haven't seen any errors. Bug: T173022 Change-Id: I432e549e24659f38171fc45c8b2d29cdef88b638 --- M src/server/components/html-page.tsx 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/marvin refs/changes/41/379741/1 diff --git a/src/server/components/html-page.tsx b/src/server/components/html-page.tsx index 449aeb2..8d7f1be 100644 --- a/src/server/components/html-page.tsx +++ b/src/server/components/html-page.tsx @@ -24,7 +24,6 @@ <meta http-equiv="x-ua-compatible" content="ie=edge" /> <meta name="viewport" content="width=device-width, initial-scale=1" /> <title>{title ? `${title} - ` : ""}Marvin</title> - <base href="/" /> <link rel="stylesheet" href={style(manifest)} /> {assets.map(path => ( <link rel="preload" href={path} {...{ as: "script" }} /> -- To view, visit https://gerrit.wikimedia.org/r/379741 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I432e549e24659f38171fc45c8b2d29cdef88b638 Gerrit-PatchSet: 1 Gerrit-Project: marvin Gerrit-Branch: master Gerrit-Owner: Jhernandez <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
