Thiemo Mättig (WMDE) has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/384007 )
Change subject: Make Entity expert consistently use rawValue
......................................................................
Make Entity expert consistently use rawValue
Change-Id: Ia8d8259ab011023306513e70213bc51d33942134
Depends-On: I052bd9a46b02c8d7f2cf11130f4230cb2251d4a8
---
M repo/resources/experts/Entity.js
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/07/384007/1
diff --git a/repo/resources/experts/Entity.js b/repo/resources/experts/Entity.js
index 1635b93..4cb140a 100644
--- a/repo/resources/experts/Entity.js
+++ b/repo/resources/experts/Entity.js
@@ -88,13 +88,13 @@
/**
* @inheritdoc
*
- * @return {string}
+ * @return {string|null}
*/
rawValue: function () {
var entitySelector = this.$input.data( 'entityselector'
),
selectedEntity =
entitySelector.selectedEntity();
- return selectedEntity ? selectedEntity.id : '';
+ return selectedEntity ? selectedEntity.id : null;
}
} );
--
To view, visit https://gerrit.wikimedia.org/r/384007
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia8d8259ab011023306513e70213bc51d33942134
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
