[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Consistently use propertyLabelOrId instead of …IdOrLabel

[WMDE]

Thiemo Mättig (WMDE) has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/384008 )

Change subject: Consistently use propertyLabelOrId instead of …IdOrLabel
......................................................................

Consistently use propertyLabelOrId instead of …IdOrLabel

This was only inconsistent in these two test files, so no big deal.

Change-Id: I09f5f5032cb77416513a93d6be9e1842cef1217b
---
M client/tests/phpunit/includes/DataAccess/PropertyIdResolverTest.php
M 
client/tests/phpunit/includes/DataAccess/Scribunto/LuaWikibaseEntityLibraryTests.lua
2 files changed, 6 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/08/384008/1

diff --git 
a/client/tests/phpunit/includes/DataAccess/PropertyIdResolverTest.php 
b/client/tests/phpunit/includes/DataAccess/PropertyIdResolverTest.php
index 95645f7..9c5fdd1 100644
--- a/client/tests/phpunit/includes/DataAccess/PropertyIdResolverTest.php
+++ b/client/tests/phpunit/includes/DataAccess/PropertyIdResolverTest.php
@@ -74,12 +74,12 @@
        /**
         * @dataProvider 
resolvePropertyIdWithInvalidInput_throwsExceptionProvider
         */
-       public function testResolvePropertyIdWithInvalidInput_throwsException( 
$propertyIdOrLabel ) {
+       public function testResolvePropertyIdWithInvalidInput_throwsException( 
$propertyLabelOrId ) {
                $propertyIdResolver = $this->getPropertyIdResolver();
 
                $this->setExpectedException( 
PropertyLabelNotResolvedException::class );
 
-               $propertyIdResolver->resolvePropertyId( $propertyIdOrLabel, 
'en' );
+               $propertyIdResolver->resolvePropertyId( $propertyLabelOrId, 
'en' );
        }
 
        public function 
resolvePropertyIdWithInvalidInput_throwsExceptionProvider() {
diff --git 
a/client/tests/phpunit/includes/DataAccess/Scribunto/LuaWikibaseEntityLibraryTests.lua
 
b/client/tests/phpunit/includes/DataAccess/Scribunto/LuaWikibaseEntityLibraryTests.lua
index 3d20045..58bb2ab 100644
--- 
a/client/tests/phpunit/includes/DataAccess/Scribunto/LuaWikibaseEntityLibraryTests.lua
+++ 
b/client/tests/phpunit/includes/DataAccess/Scribunto/LuaWikibaseEntityLibraryTests.lua
@@ -153,10 +153,10 @@
        return entity:formatPropertyValues( label )
 end
 
-local function integrationTestFormatPropertyValuesNoSuchProperty( 
propertyIdOrLabel )
+local function integrationTestFormatPropertyValuesNoSuchProperty( 
propertyLabelOrId )
        local entity = mw.wikibase.getEntityObject( 'Q199024' )
 
-       return entity:formatPropertyValues( propertyIdOrLabel )
+       return entity:formatPropertyValues( propertyLabelOrId )
 end
 
 local function integrationTestFormatPropertyValuesProperty()
@@ -178,10 +178,10 @@
        return entity:formatStatements( label )
 end
 
-local function integrationTestFormatStatementsNoSuchProperty( 
propertyIdOrLabel )
+local function integrationTestFormatStatementsNoSuchProperty( 
propertyLabelOrId )
        local entity = mw.wikibase.getEntityObject( 'Q199024' )
 
-       return entity:formatStatements( propertyIdOrLabel )
+       return entity:formatStatements( propertyLabelOrId )
 end
 
 local function integrationTestFormatStatementsProperty()

-- 
To view, visit https://gerrit.wikimedia.org/r/384008
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I09f5f5032cb77416513a93d6be9e1842cef1217b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits