Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/56347
Change subject: Return early from 'host_supports_nfs?' if Win32
......................................................................
Return early from 'host_supports_nfs?' if Win32
The current version works, but the attempt to redirect to /dev/null causes
Windows to output "The syntax of the command is incorrect", which throws users
off. This change adds a check for RUBY_PLATFORM =~ /mswin32/ which returns
early if true. This check will return false for mingw32, cygwin and JRuby, but
each of those supports the redirection to /dev/null -- it's only mswin32 that
does not.
Change-Id: I9b5de74a7c293c3d451f29db7b0eb2d7dfd23042
---
M Vagrantfile
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/vagrant
refs/changes/47/56347/1
diff --git a/Vagrantfile b/Vagrantfile
index 403bbfd..f2ba4ef 100644
--- a/Vagrantfile
+++ b/Vagrantfile
@@ -3,7 +3,9 @@
# Check if the host environment supports NFS.
def host_supports_nfs?
- system( '( nfsstat || nfsiostat ) &>/dev/null' ) and not $?.exitstatus
+ return false if RUBY_PLATFORM =~ /mswin32/
+ system( '( nfsstat || nfsiostat ) &>/dev/null' )
+ return $?.exitstatus == 0
end
Vagrant.configure('2') do |config|
--
To view, visit https://gerrit.wikimedia.org/r/56347
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9b5de74a7c293c3d451f29db7b0eb2d7dfd23042
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/vagrant
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
