jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/391044 )
Change subject: Fix test failure message
......................................................................
Fix test failure message
“⧽” (U+29FD RIGHT-POINTING CURVED ANGLE BRACKET) encoded in UTF-8 is a
legal PHP variable name component, so we have to separate it from the
real variable name with braces. This also makes the code match
ConstraintParameterParserTest, which already uses the correct version.
Change-Id: I4548dc72b5445a84baba7c1bd5e18e0860d835c5
---
M tests/phpunit/Helper/SparqlHelperTest.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
jenkins-bot: Verified
Thiemo Mättig (WMDE): Looks good to me, approved
diff --git a/tests/phpunit/Helper/SparqlHelperTest.php
b/tests/phpunit/Helper/SparqlHelperTest.php
index ec4109e..933cb1a 100644
--- a/tests/phpunit/Helper/SparqlHelperTest.php
+++ b/tests/phpunit/Helper/SparqlHelperTest.php
@@ -318,7 +318,7 @@
try {
call_user_func_array( [ $sparqlHelper,
'matchesRegularExpressionWithSparql' ], [ $text, $regex ] );
$this->assertTrue( false,
- "matchesRegularExpressionWithSparql should have
thrown a ConstraintParameterException with message ⧼$messageKey⧽." );
+ "matchesRegularExpressionWithSparql should have
thrown a ConstraintParameterException with message ⧼${messageKey}⧽." );
} catch ( ConstraintParameterException $exception ) {
$checkResult = new CheckResult(
$this->getMock( Context::class ),
--
To view, visit https://gerrit.wikimedia.org/r/391044
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4548dc72b5445a84baba7c1bd5e18e0860d835c5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseQualityConstraints
Gerrit-Branch: master
Gerrit-Owner: Lucas Werkmeister (WMDE) <lucas.werkmeis...@wikimedia.de>
Gerrit-Reviewer: Jonas Kress (WMDE) <jonas.kr...@wikimedia.de>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <thiemo.kr...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
