Petar.petkovic has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/401755 )
Change subject: Fix notifications always appearing as unseen ...................................................................... Fix notifications always appearing as unseen After Ie92b223a48 removed $flags parameter from EchoSeenTime::getTime(), we got 0 as $format passed to the method, which caused mismatch in timestamp string formats when comparing to $notifLastUnreadTime timestamp, which caused notifications to appear always as unseen (although that's unpredictable, because of wrong format used). Bug: T183076 Change-Id: Ia4ff0bc4c3b7ed80b5a22a9ca0052f1909469180 --- M includes/skins/SkinMinerva.php 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/MinervaNeue refs/changes/55/401755/1 diff --git a/includes/skins/SkinMinerva.php b/includes/skins/SkinMinerva.php index 439d47c..b0fc312 100644 --- a/includes/skins/SkinMinerva.php +++ b/includes/skins/SkinMinerva.php @@ -351,7 +351,7 @@ * @return string|bool Timestamp in TS_ISO_8601 format, or false if no stored time */ protected function getEchoSeenTime( User $user ) { - return EchoSeenTime::newFromUser( $user )->getTime( 'all', /*flags*/ 0, TS_ISO_8601 ); + return EchoSeenTime::newFromUser( $user )->getTime( 'all', TS_ISO_8601 ); } /** -- To view, visit https://gerrit.wikimedia.org/r/401755 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia4ff0bc4c3b7ed80b5a22a9ca0052f1909469180 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/skins/MinervaNeue Gerrit-Branch: master Gerrit-Owner: Petar.petkovic <ppetko...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits