jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/401755 )
Change subject: Fix notifications always appearing as unseen
......................................................................
Fix notifications always appearing as unseen
After Ie92b223a48 removed $flags parameter from EchoSeenTime::getTime(),
we got 0 as $format passed to the method, which caused mismatch in
timestamp string formats when comparing to $notifLastUnreadTime timestamp,
which caused notifications to appear always as unseen (although that's
unpredictable, because of wrong format used).
Bug: T183076
Change-Id: Ia4ff0bc4c3b7ed80b5a22a9ca0052f1909469180
---
M includes/skins/SkinMinerva.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/skins/SkinMinerva.php b/includes/skins/SkinMinerva.php
index 439d47c..b0fc312 100644
--- a/includes/skins/SkinMinerva.php
+++ b/includes/skins/SkinMinerva.php
@@ -351,7 +351,7 @@
* @return string|bool Timestamp in TS_ISO_8601 format, or false if no
stored time
*/
protected function getEchoSeenTime( User $user ) {
- return EchoSeenTime::newFromUser( $user )->getTime( 'all',
/*flags*/ 0, TS_ISO_8601 );
+ return EchoSeenTime::newFromUser( $user )->getTime( 'all',
TS_ISO_8601 );
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/401755
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia4ff0bc4c3b7ed80b5a22a9ca0052f1909469180
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/MinervaNeue
Gerrit-Branch: master
Gerrit-Owner: Petar.petkovic <ppetko...@wikimedia.org>
Gerrit-Reviewer: Catrope <r...@wikimedia.org>
Gerrit-Reviewer: Pmiazga <pmia...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
