Thiemo Kreuz (WMDE) has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/402799 )
Change subject: Use "self" references instead of repeating the class name
......................................................................
Use "self" references instead of repeating the class name
Change-Id: Ief5d859b31caae9d7b18c508e05c9e641110a638
---
M client/includes/Hooks/EditActionHookHandler.php
M client/includes/WikibaseClient.php
M lib/includes/Settings.php
M repo/includes/Content/EntityContent.php
4 files changed, 8 insertions(+), 8 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/99/402799/1
diff --git a/client/includes/Hooks/EditActionHookHandler.php
b/client/includes/Hooks/EditActionHookHandler.php
index 3332bbf..65a226a 100644
--- a/client/includes/Hooks/EditActionHookHandler.php
+++ b/client/includes/Hooks/EditActionHookHandler.php
@@ -59,7 +59,7 @@
/**
* @param IContextSource $context
- * @return EditActionHookHandler
+ * @return self
*/
public static function newFromGlobalState( IContextSource $context ) {
$wikibaseClient = WikibaseClient::getDefaultInstance();
diff --git a/client/includes/WikibaseClient.php
b/client/includes/WikibaseClient.php
index 3d9748b..f39f348 100644
--- a/client/includes/WikibaseClient.php
+++ b/client/includes/WikibaseClient.php
@@ -635,7 +635,7 @@
* IMPORTANT: Use only when it is not feasible to inject an instance
properly.
*
* @throws MWException
- * @return WikibaseClient
+ * @return self
*/
private static function newInstance() {
global $wgWBClientDataTypes;
@@ -697,7 +697,7 @@
*
* @param string $reset Flag: Pass "reset" to reset the default instance
*
- * @return WikibaseClient
+ * @return self
*/
public static function getDefaultInstance( $reset = 'noreset' ) {
static $instance = null;
diff --git a/lib/includes/Settings.php b/lib/includes/Settings.php
index cbe21aa..8e15c52 100644
--- a/lib/includes/Settings.php
+++ b/lib/includes/Settings.php
@@ -17,7 +17,7 @@
/**
* @deprecated
*
- * @return Settings
+ * @return self
*/
public static function singleton() {
static $instance = null;
diff --git a/repo/includes/Content/EntityContent.php
b/repo/includes/Content/EntityContent.php
index bfe1061..b858d23 100644
--- a/repo/includes/Content/EntityContent.php
+++ b/repo/includes/Content/EntityContent.php
@@ -534,11 +534,11 @@
/**
* Returns a diff between this EntityContent and the given
EntityContent.
*
- * @param EntityContent $toContent
+ * @param self $toContent
*
* @return EntityContentDiff
*/
- public function getDiff( EntityContent $toContent ) {
+ public function getDiff( self $toContent ) {
$fromContent = $this;
$differ = new MapDiffer();
@@ -564,7 +564,7 @@
* @param EntityContentDiff $patch
*
* @throws PatcherException
- * @return EntityContent
+ * @return self
*/
public function getPatchedCopy( EntityContentDiff $patch ) {
/* @var EntityHandler $handler */
@@ -643,7 +643,7 @@
/**
* @see Content::copy
*
- * @return EntityContent
+ * @return self
*/
public function copy() {
/* @var EntityHandler $handler */
--
To view, visit https://gerrit.wikimedia.org/r/402799
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ief5d859b31caae9d7b18c508e05c9e641110a638
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Kreuz (WMDE) <thiemo.kr...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
