jenkins-bot has submitted this change and it was merged.
Change subject: Use a UNIX timestamp in the LoggedOut cookie
......................................................................
Use a UNIX timestamp in the LoggedOut cookie
Since it is easier to interpret in VCL. The read side code strangely
does not need to be updated, and MW will continue to work with
cookies sent before this change, because wfTimestamp() automatically
detects the timestamp format.
Change-Id: I292581ca530b5e2b82f0681a8762473d06662558
---
M CentralAuthUser.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tim Starling: Looks good to me, approved
jenkins-bot: Verified
diff --git a/CentralAuthUser.php b/CentralAuthUser.php
index 0651ea2..6d5e374 100644
--- a/CentralAuthUser.php
+++ b/CentralAuthUser.php
@@ -2056,7 +2056,7 @@
$this->clearCookie( 'Session' );
// Logged-out cookie -to fix caching.
- self::setCookie( 'LoggedOut', wfTimestampNow() );
+ self::setCookie( 'LoggedOut', time() );
self::deleteSession();
}
--
To view, visit https://gerrit.wikimedia.org/r/65596
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I292581ca530b5e2b82f0681a8762473d06662558
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/CentralAuth
Gerrit-Branch: master
Gerrit-Owner: Tim Starling <tstarl...@wikimedia.org>
Gerrit-Reviewer: Tim Starling <tstarl...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
