jenkins-bot has submitted this change and it was merged.
Change subject: Use a UNIX timestamp in the LoggedOut cookie
......................................................................
Use a UNIX timestamp in the LoggedOut cookie
Since it is easier to interpret in VCL. The read side code strangely
does not need to be updated, and MW will continue to work with
cookies sent before this change, because wfTimestamp() automatically
detects the timestamp format.
Change-Id: I8c661b735b1de8e295d5d713a5ca959ee99e274e
---
M includes/User.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tim Starling: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/User.php b/includes/User.php
index 3ee32c3..2e22312 100644
--- a/includes/User.php
+++ b/includes/User.php
@@ -3146,7 +3146,7 @@
$this->clearCookie( 'forceHTTPS' );
// Remember when user logged out, to prevent seeing cached pages
- $this->setCookie( 'LoggedOut', wfTimestampNow(), time() + 86400
);
+ $this->setCookie( 'LoggedOut', time(), time() + 86400 );
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/65593
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8c661b735b1de8e295d5d713a5ca959ee99e274e
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Tim Starling <tstarl...@wikimedia.org>
Gerrit-Reviewer: Parent5446 <tylerro...@gmail.com>
Gerrit-Reviewer: Tim Starling <tstarl...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
