Dzahn has submitted this change and it was merged.
Change subject: Navigation Timing: differentiate by auth status rather than wiki
......................................................................
Navigation Timing: differentiate by auth status rather than wiki
The per-wiki metrics haven't been especially insightful; we have too many wikis
and the performance differences between them are relatively minor when simple
page views are concerned. It'd be more interesting to compare the experience of
logged-in users with anonymous visitors. So log that instead.
Change-Id: I71ae3a6879e048837ad5f87c0cf985c0f0b9a7e2
---
M files/graphite/modules/navtiming.py
1 file changed, 2 insertions(+), 5 deletions(-)
Approvals:
jenkins-bot: Verified
Dzahn: Looks good to me, approved
diff --git a/files/graphite/modules/navtiming.py
b/files/graphite/modules/navtiming.py
index 7770178..e47d0ec 100644
--- a/files/graphite/modules/navtiming.py
+++ b/files/graphite/modules/navtiming.py
@@ -58,16 +58,13 @@
event['pageSpeed'] = (
event['loadEventEnd'] - event['domInteractive'])
- wiki = meta['wiki']
- if not event.get('isAnon'):
- continue
-
site = 'mobile' if 'mobileMode' in event else 'desktop'
+ auth = 'anonymous' if event.get('isAnon') else 'authenticated'
for metric in metrics:
value = event.get(metric, 0)
if value > 0 and value < 60000:
stat = 'browser.%s.%s:%s|ms' % (metric, site, value)
sock.sendto(stat.encode('utf-8'), addr)
- stat = 'browser.%s.%s.%s:%s|ms' % (metric, wiki, site, value)
+ stat = 'browser.%s.%s.%s:%s|ms' % (metric, site, auth, value)
sock.sendto(stat.encode('utf-8'), addr)
--
To view, visit https://gerrit.wikimedia.org/r/88692
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I71ae3a6879e048837ad5f87c0cf985c0f0b9a7e2
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ori.livneh <o...@wikimedia.org>
Gerrit-Reviewer: Dzahn <dz...@wikimedia.org>
Gerrit-Reviewer: Faidon Liambotis <fai...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
