JGonera has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/89333


Change subject: Regression: Fix empty watchlist message styling
......................................................................

Regression: Fix empty watchlist message styling

Broken in db40dad

Change-Id: Ia8c0f9bc91b97c526823789885042e6e1c558b54
---
M includes/specials/SpecialMobileWatchlist.php
M less/specials/watchlist.less
M less/variables.less
3 files changed, 13 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/33/89333/1

diff --git a/includes/specials/SpecialMobileWatchlist.php 
b/includes/specials/SpecialMobileWatchlist.php
index 4e9205f..9066b7b 100644
--- a/includes/specials/SpecialMobileWatchlist.php
+++ b/includes/specials/SpecialMobileWatchlist.php
@@ -378,6 +378,7 @@
                global $wgExtensionAssetsPath;
                $output = $this->getOutput();
                $dir = $this->getLanguage()->isRTL() ? 'rtl' : 'ltr';
+               $output->setProperty( 'unstyledContent', false );
 
                // FIXME: This is necessary until new nav pushed to beta
                if ( MobileContext::singleton()->isBetaGroupMember() ) {
@@ -399,12 +400,10 @@
                $output->addHtml(
                                Html::openElement( 'div', array( 'class' => 
'info' ) ) .
                                $msg .
-                               Html::openElement( 'div' ) .
                                Html::element( 'a',
                                        array( 'class' => 'button', 'href' => 
Title::newMainPage()->getLocalUrl() ),
                                        wfMessage( 
'mobile-frontend-watchlist-back-home' )->plain()
                                ) .
-                               Html::closeElement( 'div' ) .
                                Html::closeElement( 'div' )
                );
        }
diff --git a/less/specials/watchlist.less b/less/specials/watchlist.less
index 4e21273..2b63640 100644
--- a/less/specials/watchlist.less
+++ b/less/specials/watchlist.less
@@ -28,6 +28,18 @@
        }
 }
 
+// empty watchlist message
+.info {
+       margin: 3em;
+       color: @infoColor;
+
+       img {
+               width: 100%;
+               max-width: 600px;
+               margin: 1em 0 2em;
+       }
+}
+
 // FIXME: [LiquidThreads] (see bug 53138)
 .lqt_watchlist_messages_notice {
        display: none;
diff --git a/less/variables.less b/less/variables.less
index 103d06d..8a16819 100644
--- a/less/variables.less
+++ b/less/variables.less
@@ -12,8 +12,6 @@
 // FIXME: rename to contentMargin and remove one of those, they're always the 
same
 @contentMarginRight: 16px;
 @contentMarginLeft: @contentMarginRight;
-// information messages, e.g. empty watchlist message
-@infoMargin: 4em;
 
 // article list view
 @articleListPaddingTop: 15px;

-- 
To view, visit https://gerrit.wikimedia.org/r/89333
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia8c0f9bc91b97c526823789885042e6e1c558b54
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: JGonera <jgon...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to