jenkins-bot has submitted this change and it was merged.
Change subject: Regression: Fix empty watchlist message styling
......................................................................
Regression: Fix empty watchlist message styling
Broken in db40dad
Change-Id: Ia8c0f9bc91b97c526823789885042e6e1c558b54
---
M includes/specials/SpecialMobileWatchlist.php
M less/specials/watchlist.less
M less/variables.less
3 files changed, 14 insertions(+), 4 deletions(-)
Approvals:
JGonera: Looks good to me, approved
Jdlrobson: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/includes/specials/SpecialMobileWatchlist.php
b/includes/specials/SpecialMobileWatchlist.php
index c5e894f..4fc6808 100644
--- a/includes/specials/SpecialMobileWatchlist.php
+++ b/includes/specials/SpecialMobileWatchlist.php
@@ -390,12 +390,10 @@
$output->addHtml(
Html::openElement( 'div', array( 'class' =>
'info' ) ) .
$msg .
- Html::openElement( 'div' ) .
Html::element( 'a',
array( 'class' => 'button', 'href' =>
Title::newMainPage()->getLocalUrl() ),
wfMessage(
'mobile-frontend-watchlist-back-home' )->plain()
) .
- Html::closeElement( 'div' ) .
Html::closeElement( 'div' )
);
}
diff --git a/less/specials/watchlist.less b/less/specials/watchlist.less
index 4e21273..888b414 100644
--- a/less/specials/watchlist.less
+++ b/less/specials/watchlist.less
@@ -28,6 +28,20 @@
}
}
+// empty watchlist message
+// FIXME: Can we generalise these rules into a common design pattern?
+.info {
+ margin: 3em;
+ color: @infoColor;
+
+ img {
+ width: 100%;
+ max-width: 378px;
+ margin: 1em 0 2em;
+ display: block;
+ }
+}
+
// FIXME: [LiquidThreads] (see bug 53138)
.lqt_watchlist_messages_notice {
display: none;
diff --git a/less/variables.less b/less/variables.less
index 103d06d..8a16819 100644
--- a/less/variables.less
+++ b/less/variables.less
@@ -12,8 +12,6 @@
// FIXME: rename to contentMargin and remove one of those, they're always the
same
@contentMarginRight: 16px;
@contentMarginLeft: @contentMarginRight;
-// information messages, e.g. empty watchlist message
-@infoMargin: 4em;
// article list view
@articleListPaddingTop: 15px;
--
To view, visit https://gerrit.wikimedia.org/r/89333
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia8c0f9bc91b97c526823789885042e6e1c558b54
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: JGonera <jgon...@wikimedia.org>
Gerrit-Reviewer: JGonera <jgon...@wikimedia.org>
Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
