Ok, we are going to use the number 22 for line discipline. Regards Seb
-----Original Message----- From: Arjan van de Ven [mailto:[email protected]] Sent: Monday, November 08, 2010 10:05 PM To: Busson, SebastienX Cc: [email protected] Subject: Re: [Meego-kernel] [PATCH 29/31] BT : tty.h-new-ldisc-for-TI-WiLink-ST On 11/8/2010 12:44 PM, Arjan van de Ven wrote: > On 11/4/2010 3:30 PM, Busson, SebastienX wrote: >> From 43e7af5b34d73b269f23542b4dc9f54319719a12 Mon Sep 17 00:00:00 2001 >> From: Jonathan DE CESCO<[email protected]> >> Date: Thu, 4 Nov 2010 19:29:30 +0100 >> Subject: [PATCH] new ldisc for TI WiLink-ST >> >> --- >> include/linux/tty.h | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/include/linux/tty.h b/include/linux/tty.h >> index 587fe31..0cd4664 100644 >> --- a/include/linux/tty.h >> +++ b/include/linux/tty.h >> @@ -50,7 +50,7 @@ >> #define N_CAIF 20 /* CAIF protocol for talking to >> modems */ >> #define N_GSM0710 21 /* GSM 0710 Mux */ >> #define N_PTIR 22 /* PTI cJTAG data routing for MIPI >> P1149.7 */ >> - >> +#define N_TI_WL 23 /* for TI's WL BT, FM, GPS combo chips */ > > this patch is a huge problem. > > Upstream has assigned the number 22 to this ABI, not the number 23. > > I'm not going to accept a patch with 23 here.... oh and also 23 is used by the same PTI code in another patch if only the people who write code in this area would get their code upstream so that there wouldn't be ABI clashes --------------------------------------------------------------------- Intel Corporation SAS (French simplified joint stock company) Registered headquarters: "Les Montalets"- 2, rue de Paris, 92196 Meudon Cedex, France Registration Number: 302 456 199 R.C.S. NANTERRE Capital: 4,572,000 Euros This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. _______________________________________________ MeeGo-kernel mailing list [email protected] http://lists.meego.com/listinfo/meego-kernel
