Hi Auke, Understood. I will send a modified patch in this mailing thread.
1. Disable unnecessary log 2. Modify Macro based on dev_printk() -----Original Message----- From: Kok, Auke-jan H [mailto:[email protected]] Sent: Thursday, June 09, 2011 4:02 AM To: Chang, Samuel Cc: [email protected]; [email protected]; Wu, Ricky; Huang, Maggie; Yang, Jack Subject: Re: [Meego-kernel] [PATCH] ar6003 : reduce unnecessary log during driver loading On Wed, Jun 8, 2011 at 12:50 PM, Chang, Samuel <[email protected]> wrote: > Hi Auke, > > Thanks. > So, you mean the error print is ok but can't on console directly, right ? > The error message only can be shown by dmesg. If you have an error, by all means call dev_err(), or printk(KERN_ERR.... The kernel 'loglevel' setting will determine if your error message is printed, or not. That is, if your printk macro does the right thing (which it was not). It's not up to the driver writer to determine what goes on to the console. You are supposed to mark every message with "error", "notice", "debug", and let the user/administrator decide which messages are printed to the console. In the MeeGo Tablet kernel image, even with loglevel=CRIT (which means, only CRITICAL messages or higher priority should appear), your debug messages are still appearing on the console, and that is wrong. Auke _______________________________________________ MeeGo-kernel mailing list [email protected] http://lists.meego.com/listinfo/meego-kernel
