Hi Arjan , about the power state of camera subdevs, the original idea is to power off all subdevs (camera sensors) when there's no user application was opening this device. (the libCI breaks down all its operations to many very small ones, each one will do an open and close on the /dev/video0 file. so there're many power off&on for even a single snapshot operation) but since we updated the firmware for AF feature, each power on, we need to re-load the firmware, it will break the focus status,,, so I remove this power-off. and only do power off when the driver's suspend method is called (for example, system goes to S0i3), not every time when it is closed.
is it acceptible? Thanks, -- Yong Phone (+86) 21-61166334 Lab (+86) 21-61167881 -----Original Message----- From: Arjan van de Ven [mailto:[email protected]] Sent: Monday, June 13, 2011 11:46 AM To: He, Yong M Cc: [email protected]; Brown, Len; Accardi, Kristen C Subject: Re: [Meego-kernel] [PATCH] MRST Tablet camera driver ver-0.95 (re-send), fix 8112 On 6/12/2011 8:44 PM, He, Yong M wrote: > Hi Arjan, > > you mean the sensor firmware update is a bad idea? ... I quoted a very specific chunk of your patch with a comment. I suggest you read my comment with the code I quoted in mind, and then responding to my comment. > > Thanks, > > -- Yong > Phone (+86) 21-61166334 > Lab (+86) 21-61167881 > > > -----Original Message----- > From: Arjan van de Ven [mailto:[email protected]] > Sent: Monday, June 13, 2011 11:29 AM > To: He, Yong M > Cc: [email protected]; Brown, Len; Accardi, Kristen C > Subject: Re: [Meego-kernel] [PATCH] MRST Tablet camera driver ver-0.95 > (re-send), fix 8112 > > On 6/12/2011 8:21 PM, He, Yong M wrote: >> From: Yong He<[email protected]<mailto:[email protected]>> >> Subject: [PATCH] MRST Tablet camera driver ver-0.95 (re-send), fix 8112 >> >> Bug 8112<https://bugzilla.otcshare.org/show_bug.cgi?id=8112> *- ISP >> driver doesn't support AF (auto-focus) controlling function for 5M >> camera sensor (OV5640).* >> >> sorry for sending this BIG patch,,, >> >> AF is a new added feature, and it require sensor's firmware update >> (every time from wakeup). >> >> also, AF function need to work with exposure and gain settings >> algorithm when switched from PREVIEW mode to SNAPSHOT mode, so this >> patch added this algorithm. >> >> Signed-off-by: He, Yong<[email protected] >> <mailto:[email protected]>> >> >> --- >> >> Index: a/drivers/staging/mrstci/mrstisp/mrstisp_main.c >> >> =================================================================== >> >> --- a/drivers/staging/mrstci/mrstisp/mrstisp_main.c (revision 90) >> >> +++ a/drivers/staging/mrstci/mrstisp/mrstisp_main.c (revision 91) >> >> @@ -1409,8 +1409,8 @@ >> >> ci_isp_stop(CI_ISP_CFG_UPDATE_FRAME_SYNC); >> >> v4l2_subdev_call(isp->cameras[isp->sensor_curr].camera, video, >> s_stream, 0); >> >> } >> >> - //v4l2_subdev_call(isp->cameras[isp->sensor_curr].camera, core, >> s_gpio, 1); >> >> - mrst_isp_power_off_all_subdev(isp); >> >> + // do not power off sensor when user close file, unless user >> directly call suspend >> >> + // mrst_isp_power_off_all_subdev(isp); >> >> } >> >> kfree(file->private_data); >> >> @@ -2245,6 +2245,16 @@ >> >> > > this sounds like a really bad idea, just like it originally was a really > bad idea... > please don't do this. > _______________________________________________ MeeGo-kernel mailing list [email protected] http://lists.meego.com/listinfo/meego-kernel
