On Tue, Dec 13, 2016 at 11:29 AM, Pierre-Yves David <pierre-yves.da...@ens-lyon.org> wrote: > > > On 12/12/2016 04:12 PM, Augie Fackler wrote: >> >> Can we just align with prevailing Python style here and start using >> all caps for constants? This comes up roughly monthly, and I think >> it'd be a good clarity win. > > > As much as there is many thing in our current coding still, it is our > current coding style and our codebase is consistent with it for the very > vast majority.
Restated: the codebase is inconsistent. > As stated previously, my current stance is that we should > refrain for changing this category for policy for about one year after Matt > stepped away. To what end? (If I knew about this position of yours, I forgot about it, so we get to have the discussion as to why we'd have this policy now). > So I would like us to keep to lower case constants for now. > At the 4.4 sprint, I'll be very happy to have a large discussion about our > style (and very happy to us CAPS for constant at that time). There seems to be pretty strong consensus already that CAPS for constants is a standard thing, and it keeps tripping up both new and seasoned contributors. I'd much rather change this today. _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
