On 12/24/2016 07:34 PM, Rémi Chaintron wrote:
Sounds good to me, I'm happy to follow the comment in revlog.py
hum, the comment in revlog.py is also talking about metadata…
I've updated your patch to reuse the very same wording as in revlog.py
(for consistency), and pushed the first one. (test-check-commit.t says hi)
I'll review the rest later.
On Sat, 24 Dec 2016 at 13:31 Pierre-Yves David
<pierre-yves.da...@ens-lyon.org <mailto:pierre-yves.da...@ens-lyon.org>>
wrote:
On 12/24/2016 05:36 PM, Remi Chaintron wrote:
> # HG changeset patch
> # User Remi Chaintron <r...@fb.com <mailto:r...@fb.com>>
> # Date 1482451718 18000
> # Thu Dec 22 19:08:38 2016 -0500
> # Node ID c1bd9b7750cdfe1f2a1437e4ba0ed8f6e48b2dd1
> # Parent 4f72f28e527c72cae072880b8fa1610c0289dded
> documentation: better censor flag documentation.
>
> diff --git a/mercurial/help/internals/revlogs.txt
b/mercurial/help/internals/revlogs.txt
> --- a/mercurial/help/internals/revlogs.txt
> +++ b/mercurial/help/internals/revlogs.txt
> @@ -89,7 +89,7 @@
> Absolute offset of revision data from beginning of revlog.
> 6-7 (2 bytes)
> Bit flags impacting revision behavior. The following bit
offsets define:
> - 0: 'censor' extension flag.
> + 0: REVIDX_ISCENSORED indicates the revision has censored metadata.
From my understanding of censor, I would have expected something more
like "the revision content is censored". If I remember correctly, the
censors flag means the revision content has been nuked, the metadata are
more a secondary things that give a bit more details about that nuking.
What do you think ?
> 8-11 (4 bytes)
> Compressed length of revision data / chunk as stored in revlog.
> 12-15 (4 bytes)
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@mercurial-scm.org
<mailto:Mercurial-devel@mercurial-scm.org>
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
>
--
Pierre-Yves David
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
<mailto:Mercurial-devel@mercurial-scm.org>
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
--
Rémi
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
--
Pierre-Yves David
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
