On 01/11/2017 04:40 AM, Jun Wu wrote:
Excerpts from Pierre-Yves David's message of 2017-01-10 18:22:39 +0100:
On 01/10/2017 03:45 PM, Yuya Nishihara wrote:
On Tue, 10 Jan 2017 07:12:27 +0800, Jun Wu wrote:
# HG changeset patch
# User Jun Wu <qu...@fb.com>
# Date 1484002779 -28800
# Tue Jan 10 06:59:39 2017 +0800
# Node ID 24c7b11cecd12762d8238ec96c748131877054be
# Parent e44b1d6deadb67908b43909ad920572e3efa38e6
# Available At https://bitbucket.org/quark-zju/hg-draft
# hg pull https://bitbucket.org/quark-zju/hg-draft -r 24c7b11cecd1
chg: remove getpager support
We have enough bits to switch to the new chg pager code path in runcommand.
So just remove the legacy getpager support.
This is a red-only patch, and will break chg's pager support temporarily.
I love red patches. Queued the series, thanks!
Hooray for removing much code!
I'm curious about the breakage however. It is not too important because
chg is experimental but is that breakage fixed by the next changeset?
could have reordered or folded this patch to avoid being temporarily broken?
If Patch 7 and Patch 8 were folded, there would be no breakage.
They are separated to comply with the small commit workflow.
For the record, I put the "no breakage between commit" principle before
the "small commit submission" one (and we can usually adapt the slicing
of commit to keep both).
(But, that's not too important in this case so I've accepted these patch
yesterday anyway)
--
Pierre-Yves David
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
