> Also: Jun has suggested to me that we should avoid using "Accept > Commit", because that should be a state applied only when a commit is > queued to `hg-committed` (either by the reviewer or by a future bot). > Once the commit goes to `hg` it should be automatically closed (this > should happen today out of the box). > > Those two things make sense to me, but it's the first I've heard of > it, and wanted to make sure there was consensus.
Although, hm, I find this rather annoying because I have to check whether a review is a core review or an fb-hgext review before I know if I can use the Accept functionality. :/ > Ugh. Looks way too chatty/cluttered for my taste so far (I'm mostly > lurking the list). I wouldn't despair; styling can be changed. On Wed, Jul 12, 2017 at 11:55 AM, Durham Goode <dur...@fb.com> wrote: > On 7/12/17 9:21 AM, Durham Goode wrote: >> >> >> On 7/10/17 1:00 PM, Kevin Bullock wrote: >>> >>> Greetings, Mercurial hackers! >>> >>> We've set up an instance of Phabricator that we're going to experiment >>> with for code reviews. At this time, we're not planning on using any >>> of the other features of Phabricator, and the use of Phabricator for >>> reviews is very much *an experiment* - we intend to see how this is >>> going in a little while (probably around the start of the 4.4 cycle). >>> If you're more comfortable submitting and reviewing patches as plain >>> email, that's fine - use of Phabricator is optional. In the meantime, >>> you'll see e-mails coming to the mailing list when activity happens in >>> Phabricator--hopefully we've hit the right settings to make this >>> useful without being too chatty. >>> >>> See >>> >>> https://urldefense.proofpoint.com/v2/url?u=https-3A__www.mercurial-2Dscm.org_wiki_Phabricator&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=nuarHzhP1wi1T9iURRCj1A&m=QbsrhmbnW2idG1v6iKqrCkrKcr0GyzjxWOfT4annRhM&s=fFYzxmctyERZH1yeaOlZoajPSmBKUtxCO4mr2OzRwok&e= >>> for a little more detail, including how to submit new reviews. >>> >>> Thanks, >>> Augie and Kevin >> >> >> I've created three projects in phabricator that can be used for tagging >> code reviews and creating herald rules around. >> >> If you add yourself to the 'hg' project, you will get notified of any >> review that contains #hg in the reviewers list. >> >> Add yourself to 'fbhgext' (#fb or #fbhgext) to get notified of patches >> for the facebook hg experimental repo. >> >> Add yourself to 'east' (#easy) to get notified or see reviews that are >> marked as easy. > > > I've created two dashboards for Phabricator. > > One for HG reviews: > https://phab.mercurial-scm.org/dashboard/view/1/ > > One for fb-hgext reviews: > https://phab.mercurial-scm.org/dashboard/view/2/ > > You can add them to your home page by clicking the "Install Dashboard" > button in the top right, then choosing "Personal". This way, when I go to > https://phab.mercurial-scm.org/ I see the core HG reviews front and center. > > The only problem is they currently don't group them by stack, and there's no > way to distinguish between a review that is receiving comments and one that > hasn't received any comments at all. > > _______________________________________________ > Mercurial-devel mailing list > Mercurial-devel@mercurial-scm.org > https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel