indygreg added inline comments. INLINE COMMENTS
> yuja wrote in Cargo.lock:1 > Perhaps Cargo.lock should be excluded from the commit. According to https://doc.rust-lang.org/cargo/faq.html#why-do-binaries-have-cargolock-in-version-control-but-not-libraries (and other places I found on the Internet), `Cargo.lock` files under version control are a good practice for binaries - but not libraries. Since this `Cargo.lock` encompasses the `hgcli` binary, I think that counts. FWIW, Firefox vendors `Cargo.lock` files for libraries. Although those libraries are attached to C++ binaries, so there isn't an appropriate Rust binary to attach to. But a main purpose of `Cargo.lock` files is to add determinism. For that reason, I think we want them vendored. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1581 To: indygreg, #hg-reviewers, yuja Cc: yuja, quark, durin42, dlax, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
