indygreg marked 7 inline comments as done. indygreg added a comment.
I'll address this and other review feedback in follow-up patches. Thanks for the review! INLINE COMMENTS > cramertj wrote in main.rs:45 > Nit: you can just write `&str`. Also, I'm not familiar with what you're > trying to do here, but is the PYTHON_INTERPRETER always determined at > compile-time? It seems like something you might want to switch on at runtime. > Is that not the case? This is meant to be dynamic. The gist of this code is we're trying to find the location of the Python install given various search strategies. The search strategy is (currently) defined at compile time. And this `localdev` search strategy defines the path to Python at compile time. Look for my features and documentation for this code later. (I stripped out unused code from this patch to make it smaller.) REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1581 To: indygreg, #hg-reviewers, yuja, durin42 Cc: cramertj, yuja, quark, durin42, dlax, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
