Ivzhh added a comment.
In https://phab.mercurial-scm.org/D2057#44269, @yuja wrote: > >> Reading that page it seems to claim that filenames should be utf8, not bytes. If utf8, this is what the code does, but if it is bytes that definitely won't work. > > > > IIRC it's bytes everyplace except Windows, where we pretend utf8 is real? > > It's MBCS (i.e. ANSI multi-byte characters) on Windows. The plain was to support > both MBCS and UTF-8-variant on Windows, but that isn't a thing yet. > > Perhaps we'll have to write a platform compatibility layer (or serialization/deserialization > layer) on top of the Rust's file API, something like vfs.py we have in Python code. Thank you for confirming that, I am a bit confusing when I read Encoding Plan wiki page. I am looking at Mozilla's rust winapi bindings, let me see if I can directly wrap around winapi::um::fileapi::FindFirstFileA <https://docs.rs/winapi/*/x86_64-pc-windows-msvc/winapi/um/fileapi/fn.FindFirstFileA.html> REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2057 To: Ivzhh, #hg-reviewers, kevincox Cc: yuja, glandium, krbullock, indygreg, durin42, kevincox, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
