pulkit added a comment.
The code looks mostly good to me. Needs tests for following cases:
- when working directory is dirty
- when we are in an uncommitted merge state
- there is some bookmark movement code, tests for that
INLINE COMMENTS
> commands.py:1508
> + if not message:
> + raise error.Abort(_("No commit message specified with -l or -m"))
> + extra = { 'close': '1' }
we use all lowercase error messages, so this should be "no commit ..".
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D3557
To: joerg.sonnenberger, #hg-reviewers
Cc: pulkit, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
