pulkit added inline comments.

INLINE COMMENTS

> martinvonz wrote in narrowbundle2.py:54
> Do you plan to add support for ellipses to this too? I don't know if you need 
> that feature, but I think the coming wire protocol command should eventually 
> gain support for ellipsis nodes. Do you think a TODO about that makes sense? 
> (I imagine it requires including the "known" set if the local repo has the 
> ellipses requirement.)

I do plan to support ellipses with the wireprotocol command. Since ellipses 
case will require sending a bundle not a changegroup, I plan to make that as a 
seperate function and call the required functions depending on ellipses is 
enabled or not.

Yeah the "known" set is needed. I also forgot to include that in wireprotocol 
command. Thanks!

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D4786

To: pulkit, durin42, #hg-reviewers
Cc: martinvonz, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to