martinvonz accepted this revision. martinvonz added inline comments. This revision is now accepted and ready to land.
INLINE COMMENTS > pulkit wrote in narrowbundle2.py:54 > > since ellipses case will require sending a bundle not a changegroup > > I said that because there is a 'narrow:changespec' part being send from the > server. > > I still need to understand the ellipses case more in detail but I agree that > "known" set can be helpful. > > > Maybe we should still wrap the returned changegroup in a bundle so we have > > more flexibility? It may be useful at least for letting the server include > > messages for the client. It's hard to say what else we may want to include > > in the bundle later. > > This was a very good suggestion, thanks! > I said that because there is a 'narrow:changespec' part being send from the > server. I assumed that was the reason :) But I don't think we'll need that part because we don't need to strip nodes in the ellipsis case either. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4786 To: pulkit, durin42, #hg-reviewers, martinvonz Cc: martinvonz, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
