martinvonz added inline comments. INLINE COMMENTS
> perf.py:2299 > else: > - view._branchcaches.pop(filtername, None) > + view._branchcaches._per_filter.pop(filtername, None) > view.branchmap() Same here: I think this needs to be made compatible with both versions (before and after this patch) > localrepo.py:2077 > self.ui.debug('updating the branch cache\n') > - branchmap.updatecache(self.filtered('served')) > + self.filtered('served').branchmap() > Hmm, it's much less clear now that this updates the cache. At the very least, it deserves a comment. Is the `updatecache()` call from `__getitem__()` necessary for your later patches? Sorry, I didn't quite follow. > streamclone.py:16 > from . import ( > branchmap, > cacheutil, `test-check-pyflakes.t` says that this is now unused REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5638 To: mjpieters, #hg-reviewers Cc: martinvonz, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel