martinvonz added inline comments. INLINE COMMENTS
> mjpieters wrote in localrepo.py:2077 > Yes, the updating will change in a later, as yet to be submitted patch. > > But why should it be clear //here// that there is a cache that is kept > up-to-date on access to the branchmap? That's a responsibility of the cache, > not of whatever accesses a branchmap. The cache is an implementation detail > of branchmap, and should really not bleed out into code that merely consumes > the map. Fair enough, it doesn't have to be clear that it updates the cache, but it has to be clear that it does *something*. It currently looks like a statement that can be removed, but I assume it cannot. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5638 To: mjpieters, #hg-reviewers Cc: martinvonz, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
