martinvonz added a comment.
In https://phab.mercurial-scm.org/D6255#91146, @martinvonz wrote: > In https://phab.mercurial-scm.org/D6255#91019, @martinvonz wrote: > > > In https://phab.mercurial-scm.org/D6255#91015, @marmoute wrote: > > > > > > > > > > > Since this seems the very same code as the previous clause, I wonder if > > we could factor it out. This would help to prevent subtle bug when we > > update it. (the answer might be "no because python is slow). > > > Yes, I also considered that. I wasn't sure what a good name for the method would be and I gave up. I'll try again. I've picked a name and done the refactoring now. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6255 To: martinvonz, #hg-reviewers Cc: marmoute, mjpieters, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
