martinvonz added a comment.
Replying to just a few things now. Will reply to the rest later. In https://phab.mercurial-scm.org/D6255#91019, @martinvonz wrote: > In https://phab.mercurial-scm.org/D6255#91015, @marmoute wrote: > > > I did a first path through it, the new code seems reasonable and easier > > to read than the previous one. Some comments and questions below. > > > The rest somehow didn't make it here, so I'll copy from the email (i.e. the below is from Pierre-Yves, not from me): > > I did a first path through it, the new code seems reasonable and easier > to read than the previous one. Some comments and questions below. Thanks for reviewing! >> I've run tests with hard-coded debug logging for "fullcopy" and while >> I haven't looked at every difference it produces, all the ones I have >> looked at seemed reasonable to me. > > How many difference did you had? can you share some example of them with > their explanation? Without explanation :), see http://paste.debian.net/1077862/ It just seemed to long to include in the commit message. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6255 To: martinvonz, #hg-reviewers Cc: marmoute, mjpieters, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
